Uh oh!
There was an error while loading. Please reload this page.
feat(core): support metadata reflection for native class types - #22356
feat(core): support metadata reflection for native class types#22356vicb wants to merge 1 commit into
Conversation
googlebot
commented
Feb 21, 2018
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
mary-poppins
commented
Feb 21, 2018
You can preview d7f7583 at https://pr22356-d7f7583.ngbuilds.io/. |
mary-poppins
commented
Feb 22, 2018
You can preview ee11579 at https://pr22356-ee11579.ngbuilds.io/. |
trotyl
commented
May 9, 2018
Just got that base class doesn't have to be an classDerivedextends_some__WEBPACK_IMPORTED_MODULE_1__["Base"]{constructor(){super(...arguments);}}And this won't work then. But should be OK for production in favor of scope hoisting. Seems this check should be deprecated as per #22642 comes, I'm not sure whether it should be fixed. |
Fixes that the table does not render properly when used inside of a ES2015 application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class. * angular/angular#22642 * angular/tsickle#760Fixesangular#9329
Fixes that some components does not render properly when used inside of a ES2015 JIT application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class. * angular/angular#22642 * angular/tsickle#760 See the more detailed issue here: angular#12760Fixesangular#9329.
Fixes that some components does not render properly when used inside of a ES2015 JIT application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class. * angular/angular#22642 * angular/tsickle#760 See the more detailed issue here: #12760Fixes#9329.
Fixes that some components does not render properly when used inside of a ES2015 JIT application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class. * angular/angular#22642 * angular/tsickle#760 See the more detailed issue here: #12760Fixes#9329.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
closes#21731
supersedes #22315 (rebased version).
Original PR has all required approval for merging.