Skip to content

test(ivy): update sidenav and drawer root causes - #28972

Closed
crisbeto wants to merge 1 commit into
angular:masterfrom
crisbeto:FW-1086/sidenav-root-causes
Closed

test(ivy): update sidenav and drawer root causes#28972
crisbeto wants to merge 1 commit into
angular:masterfrom
crisbeto:FW-1086/sidenav-root-causes

Conversation

@crisbeto

@crisbetocrisbeto commented Feb 26, 2019

Copy link
Copy Markdown
Member

Updates the root causes for the MatDrawer and MatSidenav tests. All of the MatDrawer failures were fixed by angular/components#15300.

@crisbeto
test(ivy): update sidenav and drawer root causes
79d387c
Updates the root causes for the `MatDrawer` and `MatSidenav` tests. All of the `MatDrawer` failures were fixed by angular/components#15300.
@crisbetocrisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer comp: ivy labels Feb 26, 2019
@crisbeto
crisbeto requested review from a teamFebruary 26, 2019 08:09
@ngbotngbotBot added this to the needsTriage milestone Feb 26, 2019
kara
kara approved these changes Feb 26, 2019
View reviewed changes

@karakara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karakara added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 26, 2019
@kara

kara commented Feb 26, 2019

Copy link
Copy Markdown
Contributor

merge-assistance: core approval should be sufficient for this

@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 14, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@karakarakara approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesmerge: caretaker noteAlert the caretaker performing the merge to check the PR for an out of normal action needed or notetarget: majorThis PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto@kara@googlebot