Skip to content

refactor(dart/transform): Remove reflectPropertiesAsAttributes - #5512

Closed
kegluneq wants to merge 1 commit into
angular:masterfrom
kegluneq:deprecated_option
Closed

refactor(dart/transform): Remove reflectPropertiesAsAttributes#5512
kegluneq wants to merge 1 commit into
angular:masterfrom
kegluneq:deprecated_option

Conversation

@kegluneq

Copy link
Copy Markdown

Remove deprecated reflectPropertiesAsAttributes as an option. It has
been renamed reflect_properties_as_attributes.

Closes#5108

Remove deprecated `reflectPropertiesAsAttributes` as an option. It has
been renamed `reflect_properties_as_attributes`.
Closesangular#5108
@kegluneqkegluneq added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews comp: dart-transformer action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 30, 2015
@vsavkinvsavkin added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 30, 2015
@vsavkinvsavkin assigned kegluneq and unassigned vsavkinNov 30, 2015
@kegluneqkegluneq added action: merge The PR is ready for merge by the caretaker refactoring Issue that involves refactoring or code-cleanup and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 30, 2015
@naomiblacknaomiblack modified the milestone: beta-00Nov 30, 2015
@kegluneqkegluneq assigned vsavkin and unassigned kegluneqDec 1, 2015
@mary-poppins

Copy link
Copy Markdown

Merging PR #5512 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5512.

@kegluneq
kegluneq deleted the deprecated_option branch December 3, 2015 20:57
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 7, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesrefactoringIssue that involves refactoring or code-cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After 30 Nov, remove reflectPropertiesAsAttributes from common/options.dart and common/options_reader.dart.

5 participants

@kegluneq@mary-poppins@vsavkin@naomiblack@googlebot