Skip to content

fix(transformer): record HostBinding annotations applied to getters - #6283

Closed
vsavkin wants to merge 1 commit into
angular:masterfrom
vsavkin:fix_transformer_host_binding_annotation
Closed

fix(transformer): record HostBinding annotations applied to getters#6283
vsavkin wants to merge 1 commit into
angular:masterfrom
vsavkin:fix_transformer_host_binding_annotation

Conversation

@vsavkin

@vsavkinvsavkin commented Jan 6, 2016

Copy link
Copy Markdown
Contributor

Closes#4407

@vsavkinvsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 6, 2016
vicb
vicb reviewed Jan 6, 2016
View reviewed changes
Comment threadmodules_dart/transform/lib/src/transform/common/type_metadata_reader.dart Outdated

@vicbvicbJan 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add && node.isGetter (& test)

@vicbvicb added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 6, 2016
@vsavkin
vsavkinforce-pushed the fix_transformer_host_binding_annotation branch from 9bcbebe to d43b55eCompareJanuary 6, 2016 02:57
@vsavkinvsavkin removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 6, 2016
@vsavkinvsavkin assigned vsavkin and unassigned vicbJan 6, 2016
@vsavkinvsavkin added the action: merge The PR is ready for merge by the caretaker label Jan 6, 2016
@IgorMinar

IgorMinar commented Jan 20, 2016

Copy link
Copy Markdown
Contributor

@jeffbcross any reason why this hasn't been merged yet?

// @rkirov

@mary-poppins

mary-poppins commented Jan 21, 2016

Copy link
Copy Markdown

Merging PR #6283 on behalf of @rkirov to branch presubmit-rkirov-pr-6283.

@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 7, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 7, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vsavkinvsavkin

Labels

action: mergeThe PR is ready for merge by the caretakercla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Dart] Transformers handling of Input, Output, HostBinding and HostListener

6 participants

@vsavkin@IgorMinar@mary-poppins@vicb@rkirov@googlebot