Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Event vs KeyboardEvent #885

Description

@LucasSloan

I saw 2 instances of this error, there might be more. Basically, the Closure type system has much broader base types than the TypeScript type system. So in Closure, the type Event had all the properties of the TypeScript type KeyboardEvent. Gents translated the type to just Event, so it had to be manually changed to the more precise KeyboardEvent. There was a similar issue with Element and HTMLElement.

I think the fix is to introduce ClosureEvent and ClosureElement types that match the actual types of the Closure Event and Element (and probably more built-ins).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions