Skip to content

fix(expansion-panel): entire body content being shown on animation start - #10138

Merged
tinayuangao merged 1 commit into
angular:masterfrom
crisbeto:10134/expansion-panel-animation-overflow
Mar 1, 2018
Merged

fix(expansion-panel): entire body content being shown on animation start#10138
tinayuangao merged 1 commit into
angular:masterfrom
crisbeto:10134/expansion-panel-animation-overflow

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Fixes expansion panels becoming overflow: visible as soon as their expansion animation starts, causing them to show the entire content before they're done animating. It seems like we were setting the mat-expanded class both through the view and manually when the animation is done.

Fixes#10134.

Fixes expansion panels becoming `overflow: visible` as soon as their expansion animation starts, causing them to show the entire content before they're done animating. It seems like we were setting the `mat-expanded` class both through the view and manually when the animation is done.
Fixesangular#10134.
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 25, 2018

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 26, 2018
@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Feb 26, 2018
@josephperrott

Copy link
Copy Markdown
Member

I actually have a PR (#8829) currently to move to use display rather than visibility, We might need to end up doing both, but I am not 100% sure.

@tinayuangao
tinayuangao merged commit b4b76bd into angular:masterMar 1, 2018
tinayuangao pushed a commit that referenced this pull request Mar 5, 2018
…art (#10138)
Fixes expansion panels becoming `overflow: visible` as soon as their expansion animation starts, causing them to show the entire content before they're done animating. It seems like we were setting the `mat-expanded` class both through the view and manually when the animation is done.
Fixes#10134.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 8, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mat-expansion-panel's content shows immediately, outrunning the panel's animation

5 participants

@crisbeto@josephperrott@jelbourn@googlebot@tinayuangao