Skip to content

fix(datepicker): toggle should inherit color from mat-form-field through mat-datepicker - #10245

Merged
jelbourn merged 1 commit into
angular:masterfrom
mmalerba:dp-docs
Mar 6, 2018
Merged

fix(datepicker): toggle should inherit color from mat-form-field through mat-datepicker#10245
jelbourn merged 1 commit into
angular:masterfrom
mmalerba:dp-docs

Conversation

@mmalerba

Copy link
Copy Markdown
Contributor

Also adds docs for color feature.

Fixes#10221

@mmalerbammalerba added pr: needs review target: major This PR is targeted for the next major release labels Mar 2, 2018
@mmalerbammalerba added this to the 6.0 milestone Mar 2, 2018
@mmalerba
mmalerba requested a review from crisbetoMarch 2, 2018 19:33
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 2, 2018

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Mar 2, 2018

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

Comment threadsrc/lib/datepicker/datepicker.ts Outdated
@Input()
get color(): ThemePalette {
return this._color ||
(this._datepickerInput ? this._datepickerInput ._getThemePalette() : undefined);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space before the question mark and the ._getThemePalette.

@jelbourn
jelbourn merged commit 749f2a0 into angular:masterMar 6, 2018
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 8, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: majorThis PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

datepicker: document new features for 6.0.0

4 participants

@mmalerba@jelbourn@crisbeto@googlebot