Skip to content

feat(stepper): add CdkStepHeader directive and fix CdkStepper error on init - #10614

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:10611/cdk-step-header
Oct 25, 2018
Merged

feat(stepper): add CdkStepHeader directive and fix CdkStepper error on init#10614
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:10611/cdk-step-header

Conversation

@crisbeto

@crisbetocrisbeto commented Mar 29, 2018

Copy link
Copy Markdown
Member
  • Adds the CdkStepHeader directive which is the equivalent of MatStepHeader and can be used by consumers when building custom steppers.
  • Fixes an error that was being thrown on init when using a cdkStepper directly.

Fixes#10611.

@crisbeto
crisbeto requested a review from mmalerba as a code ownerMarch 29, 2018 09:54
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 29, 2018
@mmalerbammalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed pr: needs review labels Mar 29, 2018
@crisbeto
crisbetoforce-pushed the 10611/cdk-step-header branch from 06a03b5 to a45d4a2CompareApril 1, 2018 16:41
@kherock

kherock commented Apr 11, 2018

Copy link
Copy Markdown
Contributor

Any reason this is taking a bit longer to merge? I was hoping this would have made it into the last RC.

@mmalerba

mmalerba commented Apr 24, 2018

Copy link
Copy Markdown
Contributor

When we did the presubmit against Google's code it looks like there was a team that was extending CdkStepper and this broke their build. We need to update their app in order to merge this

@mmalerbammalerba added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 24, 2018
@andrewseguinandrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Apr 26, 2018
@kherock

kherock commented May 4, 2018

Copy link
Copy Markdown
Contributor

This didn't make it into the 6.0 release :(

@ngbot

ngbotBot commented May 11, 2018

Copy link
Copy Markdown

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto
crisbetoforce-pushed the 10611/cdk-step-header branch from a45d4a2 to 8ce96a3CompareMay 12, 2018 07:57
@josephperrottjosephperrott removed the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Aug 7, 2018
@ngbot

ngbotBot commented Aug 21, 2018

Copy link
Copy Markdown

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

1 similar comment
@ngbot

ngbotBot commented Aug 21, 2018

Copy link
Copy Markdown

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto
crisbetoforce-pushed the 10611/cdk-step-header branch from 8ce96a3 to 50c5ffeCompareAugust 25, 2018 17:22
@crisbeto
crisbetoforce-pushed the 10611/cdk-step-header branch from 50c5ffe to 9f9939fCompareSeptember 3, 2018 20:19
@ngbot

ngbotBot commented Sep 18, 2018

Copy link
Copy Markdown

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@kherock

kherock commented Oct 20, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Is this going to be merged soon? It's a bit silly that 7 months and two major releases later this is still an issue.

@eeugeen

eeugeen commented Oct 24, 2018

Copy link
Copy Markdown

@kherock

- This didn't make it into the 6.0 release :(+ This didn't make it into the 7.0 release :(

@kherock

kherock commented Oct 24, 2018

Copy link
Copy Markdown
Contributor

@mmalerba Can this get merged for 7.x please? This isn't marked with presubmit failures as of 2 months ago.

mmalerba
mmalerba approved these changes Oct 24, 2018
View reviewed changes
Comment threadsrc/cdk/stepper/stepper.ts Outdated

/** The list of step headers of the steps in the stepper. */
_stepHeader: QueryList<FocusableOption>;
@ContentChildren(CdkStepHeader) _stepHeader: QueryList<CdkStepHeader>;

@mmalerbammalerbaOct 24, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crisbeto this is technically a breaking change right now, can you change it to this instead:

@ContentChildren(CdkStepHeader) _stepHeader: QueryList<FocusableOption>;

@crisbetocrisbetoOct 25, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I didn't consider it a breaking change, because the property is underscored.

@crisbeto
feat(stepper): add CdkStepHeader directive and fix CdkStepper error o…
462811c
…n init
* Adds the `CdkStepHeader` directive which is the equivalent of `MatStepHeader` and can be used by consumers when building custom steppers.
* Fixes an error that was being thrown on init when using a `cdkStepper` directly.
Fixesangular#10611.
@crisbeto
crisbetoforce-pushed the 10611/cdk-step-header branch from d675ba1 to 462811cCompareOctober 25, 2018 17:47
@mmalerba
mmalerba merged commit fbbe463 into angular:masterOct 25, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
@crisbeto@atscott
feat(stepper): add CdkStepHeader directive and fix CdkStepper error o…
b43b3e0
…n init (angular#10614)
* Adds the `CdkStepHeader` directive which is the equivalent of `MatStepHeader` and can be used by consumers when building custom steppers.
* Fixes an error that was being thrown on init when using a `cdkStepper` directly.
Fixesangular#10611.
@kherock

kherock commented Nov 7, 2018

Copy link
Copy Markdown
Contributor

@mmalerba I'm not seeing this in the recent 7.0.2 and 7.0.3 releases? @angular/cdk/stepper still doesn't have CdkStepHeader as an export.

@tobang

tobang commented Nov 9, 2018

Copy link
Copy Markdown

Any idea when this will be available?

@tobangtobang mentioned this pull request Nov 9, 2018
Closed
@mmalerba

mmalerba commented Nov 12, 2018

Copy link
Copy Markdown
Contributor

It's target: minor so will be in 7.1

@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mmalerbammalerbammalerba approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mmalerbammalerba

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementmerge: caretaker noteAlert the caretaker performing the merge to check the PR for an out of normal action needed or notetarget: minorThis PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CDK] Can't use cdkStepper directly since _stepHeader isn't defined

8 participants

@crisbeto@kherock@mmalerba@eeugeen@tobang@googlebot@josephperrott@andrewseguin