Uh oh!
There was an error while loading. Please reload this page.
perf(overlay): remove detached overlays from the DOM - #12414
Conversation
jelbourn
commented
Jul 27, 2018
Will this conflict with #11806? |
crisbeto
commented
Jul 27, 2018
As far as I can tell no, because the overlay in #11806 never detaches, it just toggles |
| private _backdropClick: Subject<MouseEvent> = new Subject(); | ||
| private _attachments = new Subject<void>(); | ||
| private _detachments = new Subject<void>(); | ||
| private _previousHostParent: HTMLElement; |
There was a problem hiding this comment.
Add a description for this that explains how its used?
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
Removes the detached overlays from the DOM, rather than keeping their host element. Previously we kept the elements in the DOM, because they don't interfere with user interactions and it made it easier to handle animations, however doing so can cause scroll jank, because the host still has dimensions and is being rendered by the browser. Fixesangular#12341.
1319612 to
ed490c4CompareRemoves the detached overlays from the DOM, rather than keeping their host element. Previously we kept the elements in the DOM, because they don't interfere with user interactions and it made it easier to handle animations, however doing so can cause scroll jank, because the host still has dimensions and is being rendered by the browser. Fixes#12341.
Removes the detached overlays from the DOM, rather than keeping their host element. Previously we kept the elements in the DOM, because they don't interfere with user interactions and it made it easier to handle animations, however doing so can cause scroll jank, because the host still has dimensions and is being rendered by the browser. Fixes#12341.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Removes the detached overlays from the DOM, rather than keeping their host element. Previously we kept the elements in the DOM, because they don't interfere with user interactions and it made it easier to handle animations, however doing so can cause scroll jank, because the host still has dimensions and is being rendered by the browser.
Fixes#12341.