Skip to content

cleanup(stepper): remove unused class - #13006

Merged
vivian-hu-zz merged 1 commit into
angular:masterfrom
crisbeto:12999/custom-stepper-icon-size
Jan 17, 2019
Merged

cleanup(stepper): remove unused class#13006
vivian-hu-zz merged 1 commit into
angular:masterfrom
crisbeto:12999/custom-stepper-icon-size

Conversation

@crisbeto

@crisbetocrisbeto commented Sep 6, 2018

Copy link
Copy Markdown
Member

Fixes the stepper not setting the proper font size for custom number icons.

Fixes#12999.

@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Sep 6, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 6, 2018
mmalerba
mmalerba reviewed Oct 18, 2018
View reviewed changes
Comment threadsrc/lib/stepper/step-header.scss Outdated
height: $mat-step-header-icon-size;
width: $mat-step-header-icon-size;
.mat-step-icon,
.mat-step-icon-not-touched {

@mmalerbammalerbaOct 18, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this class has since been removed

@crisbetocrisbetoOct 18, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still one selector in master that's referring to it.

@mmalerbammalerbaOct 18, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove it then, because the class is never actually applied to any elements

@crisbetocrisbetoOct 18, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@crisbetocrisbetoOct 18, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this ended up being reduced to just removing that extra selector. I can close it if necessary.

@crisbeto
crisbetoforce-pushed the 12999/custom-stepper-icon-size branch from 74285bd to f61e9d2CompareOctober 18, 2018 21:11
@ngbot

ngbotBot commented Oct 23, 2018

Copy link
Copy Markdown

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto
crisbetoforce-pushed the 12999/custom-stepper-icon-size branch from f61e9d2 to 726e053CompareOctober 24, 2018 19:59
@mmalerbammalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 16, 2018
@mmalerbammalerba changed the title fix(stepper): inconsistent icon size for custom iconscleanup(stepper): remove unused classNov 16, 2018
@mmalerbammalerba added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Nov 16, 2018
@crisbeto
crisbetoforce-pushed the 12999/custom-stepper-icon-size branch from 726e053 to f5ff7d9CompareDecember 13, 2018 17:43
@crisbeto
fix(stepper): inconsistent icon size for custom icons
ddb6b8d
Fixes the stepper not setting the proper font size for custom number icons.
Fixesangular#12999.
@crisbeto
crisbetoforce-pushed the 12999/custom-stepper-icon-size branch from f5ff7d9 to ddb6b8dCompareJanuary 2, 2019 11:12
@vivian-hu-zz
vivian-hu-zz merged commit e982e36 into angular:masterJan 17, 2019
s2-abdo pushed a commit to s2-abdo/material2 that referenced this pull request Jan 18, 2019
@crisbetoAbderrahmane Hamila
cleanup(stepper): remove unused class (angular#13006)
299cfc9
Fixes the stepper not setting the proper font size for custom number icons.
Fixesangular#12999.
vivian-hu-zz pushed a commit that referenced this pull request Jan 18, 2019
@crisbetoVivian Hu
cleanup(stepper): remove unused class (#13006)
c6b96a2
Fixes the stepper not setting the proper font size for custom number icons.
Fixes#12999.
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mmalerbammalerbammalerba left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mmalerbammalerba

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementmerge: fix commit messageWhen the PR is merged, rewrites/fixups of the commit messages are neededtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stepper icon override not same size on not-touched steps

4 participants

@crisbeto@mmalerba@googlebot@vivian-hu-zz