Skip to content

fix(datepicker): don't allow clicks on disabled cells in year and multi-year views - #13448

Merged
josephperrott merged 1 commit into
angular:masterfrom
crisbeto:13446/datepicker-disabled-cell-click
Oct 19, 2018
Merged

fix(datepicker): don't allow clicks on disabled cells in year and multi-year views#13448
josephperrott merged 1 commit into
angular:masterfrom
crisbeto:13446/datepicker-disabled-cell-click

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Doesn't allow users to click on disabled cells inside the calendar in the year and multi-year views.

Fixes#13446.

@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Oct 5, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2018
<tr><th class="mat-calendar-table-header-divider" colspan="4"></th></tr>
</thead>
<tbody mat-calendar-body
allowDisabledSelection="true"

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmalerba this behavior seems pretty deliberate, but I'm not sure whether it makes sense. Also it only applies to mouse users, because you can't reach disabled cells with the keyboard.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like its been that way since the beginning, but I don't remember why I did it, and I agree that it doesn't really make sense. Can we also remove the allowDisabledSelection input from calendar body?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

…ti-year views
Doesn't allow users to click on disabled cells inside the calendar in the year and multi-year views.
Fixesangular#13446.
@crisbeto
crisbetoforce-pushed the 13446/datepicker-disabled-cell-click branch from 74510ef to 80edd2eCompareOctober 5, 2018 18:12
@mmalerbammalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 5, 2018
@josephperrott
josephperrott merged commit c15bad2 into angular:masterOct 19, 2018
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking on disable month or year it takes to respective view in the calendar

4 participants

@crisbeto@mmalerba@googlebot@josephperrott