Uh oh!
There was an error while loading. Please reload this page.
feat(material/dialog): add the ability to control the animation duration - #13466
Merged
Merged
Conversation
crisbetoforce-pushed
the
3616/dialog-animation-duration
branch
from
October 6, 2018 08:47
a8e5e31 to
1dead0fComparecrisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Oct 19, 2018
…uration For keeping parity with the Material dialog (angular#13466), adds the ability for consumers to configure the animation duration of the dialog.
josephperrott
commented
Oct 19, 2018
Member
Caretaker Note: Should be merged with #13694 as they are paired together. |
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
crisbetoforce-pushed
the
3616/dialog-animation-duration
branch
from
November 17, 2018 14:03
1dead0f to
b933fc1Comparecrisbetoforce-pushed
the
3616/dialog-animation-duration
branch
from
June 10, 2019 19:49
b933fc1 to
8735035Comparecrisbetoforce-pushed
the
3616/dialog-animation-duration
branch
2 times, most recently
from
September 22, 2019 17:28
15a1d63 to
1cb94b5Comparecrisbetoforce-pushed
the
3616/dialog-animation-duration
branch
2 times, most recently
from
December 25, 2019 14:25
bea7474 to
e0cd1acComparecrisbetoforce-pushed
the
3616/dialog-animation-duration
branch
from
February 25, 2020 21:43
e0cd1ac to
c678d2dCompareliesahead
commented
Nov 4, 2021
Is this is going to be merged? |
lansana
commented
Nov 8, 2021
+1 would love to see this merged as well |
crisbetoforce-pushed
the
3616/dialog-animation-duration
branch
from
November 9, 2021 08:22
c678d2d to
7b8856aComparecrisbetoforce-pushed
the
3616/dialog-animation-duration
branch
3 times, most recently
from
November 10, 2021 11:59
209fff9 to
28465beCompare1 task
crisbetoforce-pushed
the
3616/dialog-animation-duration
branch
2 times, most recently
from
March 12, 2022 10:08
36aeca8 to
0b31649CompareSince the dialog animation is on the `MatDialogContainer`, consumers aren't able to disable the animation. These changes add properties to the dialog config that allow consumers to set the duration of the dialog's enter and exit animations. Fixesangular#3616.
crisbetoforce-pushed
the
3616/dialog-animation-duration
branch
from
March 12, 2022 10:37
0b31649 to
a6cea11Compareforsti0506 pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
…ion (angular#13466) Since the dialog animation is on the `MatDialogContainer`, consumers aren't able to disable the animation. These changes add properties to the dialog config that allow consumers to set the duration of the dialog's enter and exit animations. Fixesangular#3616.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the dialog animation is on the
MatDialogContainer, consumers aren't able to disable the animation. These changes add properties to the dialog config that allow consumers to set the duration of the dialog's enter and exit animations.Fixes#3616.