Uh oh!
There was an error while loading. Please reload this page.
fix(slide-toggle): focus ripple not hiding after click/touch - #13562
Merged
jelbourn merged 1 commit intoMay 14, 2019
Conversation
devversionforce-pushed
the
fix/slide-toggle-focus-ripple
branch
from
November 8, 2018 20:06
93db2d7 to
9251451CompareHi @devversion! This PR has merge conflicts due to recent upstream merges. |
1 similar comment
Hi @devversion! This PR has merge conflicts due to recent upstream merges. |
devversionforce-pushed
the
fix/slide-toggle-focus-ripple
branch
from
November 10, 2018 08:56
9251451 to
eec3f86Comparearucar
commented
Dec 10, 2018
problem still exist |
jelbourn
commented
May 14, 2019
Contributor
@crisbeto I can get this merged if you can rebase |
crisbeto
commented
May 14, 2019
Member
This one's on @devversion. |
Similarly to the checkbox (angular#13295), the persistent ripple should only show up for focus if the slide-toggle has been focused through keyboard. https://storage.googleapis.com/spec-host-backup/mio-design%2Fassets%2F1w3KOMo81gakKP7JC6yNogxCt-CadYQvx%2Fslidercontrols-1a-v02.mp4
devversionforce-pushed
the
fix/slide-toggle-focus-ripple
branch
from
May 14, 2019 16:49
eec3f86 to
db09c1cComparedevversion
commented
May 14, 2019
MemberAuthor
Rebased 😄 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to the checkbox (#13295), the persistent ripple should only show up for focus if the slide-toggle has been focused through keyboard.
https://storage.googleapis.com/spec-host-backup/mio-design%2Fassets%2F1w3KOMo81gakKP7JC6yNogxCt-CadYQvx%2Fslidercontrols-1a-v02.mp4