Skip to content

fix(radio): only show focus ripple for keyboard focus - #13565

Merged
josephperrott merged 1 commit into
angular:masterfrom
crisbeto:13544/radio-focus-ripple
Mar 5, 2019
Merged

fix(radio): only show focus ripple for keyboard focus#13565
josephperrott merged 1 commit into
angular:masterfrom
crisbeto:13544/radio-focus-ripple

Conversation

@crisbeto

Copy link
Copy Markdown
Member

After the switch to the latest Material Design spec, we started showing the focus ripple for all kinds of focus, however it's only supposed to be for keyboard focus.

Fixes#13544.

@crisbetocrisbeto added the target: major This PR is targeted for the next major release label Oct 11, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 11, 2018

@devversiondevversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversiondevversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 11, 2018

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added blocked This issue is blocked by some external factor, such as a prerequisite PR and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Oct 16, 2018
@crisbetocrisbeto added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Oct 18, 2018
@crisbeto
crisbetoforce-pushed the 13544/radio-focus-ripple branch from 929e46e to 95b5444CompareDecember 9, 2018 09:33
@ngbot

ngbotBot commented Dec 11, 2018

Copy link
Copy Markdown

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

1 similar comment
@ngbot

ngbotBot commented Dec 11, 2018

Copy link
Copy Markdown

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto
crisbetoforce-pushed the 13544/radio-focus-ripple branch 2 times, most recently from 9e53c63 to 9865fb6CompareDecember 13, 2018 17:46
After the switch to the latest Material Design spec, we started showing the focus ripple for all kinds of focus, however it's only supposed to be for keyboard focus.
Fixesangular#13544.
@crisbeto
crisbetoforce-pushed the 13544/radio-focus-ripple branch from 9865fb6 to cfa2649CompareDecember 27, 2018 18:11
@josephperrott
josephperrott merged commit 76c2a3c into angular:masterMar 5, 2019
josephperrott pushed a commit that referenced this pull request Mar 5, 2019
After the switch to the latest Material Design spec, we started showing the focus ripple for all kinds of focus, however it's only supposed to be for keyboard focus.
Fixes#13544.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Radio button ripple effect 7.0.0-rc.1

5 participants

@crisbeto@jelbourn@devversion@googlebot@josephperrott