Uh oh!
There was an error while loading. Please reload this page.
fix(experimental/dialog): emitting events twice on some browsers - #13587
Merged
andrewseguin merged 1 commit intoOct 15, 2018
Merged
Conversation
Fixes the `Dialog` emitting some of its events twice on certain browsers due to an issue in `@angular/animations` which invokes the animation `done` callback twice. Fixesangular#13585.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Oct 14, 2018
Along the same lines as angular#13600 and angular#13587. The `animationDone` will be emitted twice in a row for some browsers due to a bug in `@angular/animations`.
josephperrott
removed their request for review
October 15, 2018 14:59
josephperrott pushed a commit
that referenced
this pull request
Oct 19, 2018
josephperrott pushed a commit
that referenced
this pull request
Oct 19, 2018
josephperrott pushed a commit
that referenced
this pull request
Oct 19, 2018
roboshoes pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
…ular#13587) Fixes the `Dialog` emitting some of its events twice on certain browsers due to an issue in `@angular/animations` which invokes the animation `done` callback twice. Fixesangular#13585.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
Dialogemitting some of its events twice on certain browsers due to an issue in@angular/animationswhich invokes the animationdonecallback twice.Fixes#13585.