Skip to content

build: move lint job to circleci - #13596

Merged
andrewseguin merged 1 commit into
angular:masterfrom
devversion:wip/switch-to-circle
Oct 15, 2018
Merged

build: move lint job to circleci#13596
andrewseguin merged 1 commit into
angular:masterfrom
devversion:wip/switch-to-circle

Conversation

@devversion

@devversiondevversion commented Oct 12, 2018•
edited
Loading

Copy link
Copy Markdown
Member
  • Runs the Lint job on CircleCI within a new workflow.
  • Adds comment for structuring the Circle config file (the file will
    become even larger in the future)

@devversiondevversion added the in progress This issue is currently in progress label Oct 12, 2018
@devversiondevversion self-assigned this Oct 12, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 12, 2018
@devversion
devversion removed the request for review from jelbournOctober 12, 2018 21:06
@devversiondevversion changed the title wip: switch to circlecibuild: move lint job to circleciOct 12, 2018
@devversiondevversion added pr: merge safe target: major This PR is targeted for the next major release and removed in progress This issue is currently in progress labels Oct 12, 2018
jelbourn
jelbourn approved these changes Oct 12, 2018
View reviewed changes

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 12, 2018
@devversion
build: move lint job to circleci
e60228d
* Runs the Lint job on CircleCI within a new workflow.
* Adds comment for structuring the Circle config file (the file will
become even larger in the future)
@devversiondevversion mentioned this pull request Oct 13, 2018
Merged
@andrewseguin
andrewseguin merged commit 8c3457b into angular:masterOct 15, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@devversion@roboshoes
build: move lint job to circleci (angular#13596)
15a9239
* Runs the Lint job on CircleCI within a new workflow.
* Adds comment for structuring the Circle config file (the file will
become even larger in the future)
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 9, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jelbournjelbournjelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jelbournjelbourn

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: majorThis PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion@jelbourn@googlebot@andrewseguin