Skip to content

chore(drag-drop): rename cdkDrop to cdkDropList - #13619

Merged
andrewseguin merged 1 commit into
angular:masterfrom
josephperrott:dnd
Oct 15, 2018
Merged

chore(drag-drop): rename cdkDrop to cdkDropList#13619
andrewseguin merged 1 commit into
angular:masterfrom
josephperrott:dnd

Conversation

@josephperrott

Copy link
Copy Markdown
Member

No description provided.

@josephperrottjosephperrott added the target: major This PR is targeted for the next major release label Oct 15, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 15, 2018
@josephperrottjosephperrott changed the title chore(drag-drop): rename cdkDrop to cdkDropCollectionchore(drag-drop): rename cdkDrop to cdkDropListOct 15, 2018

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

providers: [
{provide: CDK_DROP_CONTAINER, useExisting: CdkDrop},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably rename CDK_DROP_CONTAINER to CDK_DROP_LIST. Same goes for the CdkDropContainer interface.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be CDK_DROP_LIST_CONTAINER? It's a bit long but I think its okay for this usage.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that works too. Since this is a private thing the length doesn't matter too much.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewseguinandrewseguin added the action: merge The PR is ready for merge by the caretaker label Oct 15, 2018
@andrewseguin
andrewseguin merged commit 160b688 into angular:masterOct 15, 2018
@@ -1,3 +1,3 @@
<div cdkDrop cdkDropOrientation="horizontal" class="example-list" (cdkDropDropped)="drop($event)">
<div cdkDropList cdkDropOrientation="horizontal" class="example-list" (cdkDropListDropped)="drop($event)">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cdkDropOrientation should also be renamed to cdkDropListOrientation

crisbeto added a commit to crisbeto/material2 that referenced this pull request Oct 16, 2018
Fixes some invalid leftover references to `cdkDrop` after angular#13619.
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
@josephperrott
josephperrott deleted the dnd branch March 20, 2020 22:15
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: majorThis PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@josephperrott@sreekumarp@crisbeto@DimiDeKerf@googlebot@andrewseguin