Skip to content

build: update bazel sass rules - #13622

Merged
josephperrott merged 1 commit into
angular:masterfrom
devversion:build/update-sass-rules
Oct 16, 2018
Merged

build: update bazel sass rules#13622
josephperrott merged 1 commit into
angular:masterfrom
devversion:build/update-sass-rules

Conversation

@devversion

Copy link
Copy Markdown
Member

I've actually wanted to upgrade the SaSS rules in order to fix the source_map_support failures coming from the rules. Unfortunately the issue is not solved yet, but it doesn't hurt keeping the rules up-to-date.

See: bazelbuild/rules_sass#44

@devversiondevversion added pr: merge safe target: major This PR is targeted for the next major release labels Oct 15, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 15, 2018

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 16, 2018
@josephperrott
josephperrott merged commit 240acf6 into angular:masterOct 16, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: majorThis PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion@jelbourn@googlebot@josephperrott