Skip to content

fix(schematics): do not publish testing utilities to npm - #13633

Merged
josephperrott merged 1 commit into
angular:masterfrom
devversion:fix/schematics-do-not-publish-test-utils
Oct 16, 2018
Merged

fix(schematics): do not publish testing utilities to npm#13633
josephperrott merged 1 commit into
angular:masterfrom
devversion:fix/schematics-do-not-publish-test-utils

Conversation

@devversion

@devversiondevversion commented Oct 16, 2018

Copy link
Copy Markdown
Member
  • No longer publishes the CDK schematic testing utilities to NPM. We just re-exported them because the Angular Material schematic tests share logic with the CDK schematics. This now moves the CDK schematic testing utilities into a secondary entry-point that is just accessable for testing.

This is the error that shows up someone just runs any CDK or Material schematic

image

* No longer publishes the CDK schematic testing utilities to NPM. We just re-exported them because the Angular Material schematic tests share logic with the CDK schematics. This now moves the CDK schematic testing utilities into a secondary entry-point that is just accessable for testing.
@devversiondevversion added the P0 Issue that causes an outage, breakage, or major function to be unusable, with no known workarounds label Oct 16, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 16, 2018
@devversiondevversion added pr: merge safe target: major This PR is targeted for the next major release labels Oct 16, 2018

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 16, 2018
@josephperrott
josephperrott merged commit ef429c4 into angular:masterOct 16, 2018
@devversion
devversion deleted the fix/schematics-do-not-publish-test-utils branch October 16, 2018 19:42
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementP0Issue that causes an outage, breakage, or major function to be unusable, with no known workaroundstarget: majorThis PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion@jelbourn@googlebot@josephperrott