Uh oh!
There was an error while loading. Please reload this page.
build: run overlay and text-field tests with Bazel - #13637
Conversation
devversion
commented
Oct 16, 2018
- Implements a small and simple workaround that allows us to run the overlay and text-field unit tests through Bazel. Works around issue: https://github.com/bazelbuild/rules_typescript/issues/301
* Implements a small and simple workaround that allows us to run the overlay and text-field unit tests through Bazel. Works around issue: https://github.com/bazelbuild/rules_typescript/issues/301
@jelbourn I'm not a big fan of having such a workaround, but we need something like this in order to move on with Bazel for Maybe we can also somehow prioritize that issue within the Bazel Typescript rules. |
jelbourn
left a comment
There was a problem hiding this comment.
I thought that there was also an issue with the test suite where it doesn't let you pass browser flags, which we use to set the winder to 1024x768 so that the geometry values are consistent
| js_template="var cssElement = document.createElement('style'); \ | ||
| cssElement.type = 'text/css'; \ | ||
| cssElement.innerHTML = '$$css_content'; \ | ||
| document.head.appendChild(cssElement);" |
There was a problem hiding this comment.
Could this be a separate file that's included in the rule rather than creating it on-demand with a genrule?
There was a problem hiding this comment.
Not entirely sure what you mean? A separate rule for generating this file?
Not sure if that would be worth the effort.
This is just a matrix function, so we don't have access to a context.
There was a problem hiding this comment.
I mean creating a real js file like overlay-test-style-include.js that's added to the deps of just the overlay rule?
There was a problem hiding this comment.
I don't think that will work. I'm not sure how we could load the prebuilt CSS output into the file without a custom rule/or genrule
-- Actually it would work if we somehow know the path to the CSS file which is served by Karma (just not included)
I can look into it tomorrow, if we want to go with your proposed approach
devversion
commented
Oct 16, 2018
Yeah that's what I initially thought. I've tried to fix it just by specifying a screen resolution, but apparently that doesn't have any effect. The tests just failed due to the missing CSS styles. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |