Skip to content

build: move bazel config to workspace root - #13644

Merged
josephperrott merged 1 commit into
angular:masterfrom
devversion:build/move-bazel-rc-workspace-root
Oct 17, 2018
Merged

build: move bazel config to workspace root#13644
josephperrott merged 1 commit into
angular:masterfrom
devversion:build/move-bazel-rc-workspace-root

Conversation

@devversion

Copy link
Copy Markdown
Member
  • In order to prepare for the next bazel releases, we need to move the tools/bazel.rc to %workspace_root%/.bazelrc. The new location is already supported by 0.17.1+, but tools/.bazel.rc has been just left for backwards compatibility.
  • Also updates the bazel config to be more in sync with the bazelrc from angular/angular.

* In order to prepare for the next bazel releases, we need to move the `tools/bazel.rc` to `%workspace_root%/.bazelrc`. The new location is already supported by 0.17.1+, but `tools/.bazel.rc` has been just left for backwards compatibility.
* Also updates the bazel config to be more in sync with the bazelrc from `angular/angular`.
@devversiondevversion added pr: merge safe target: major This PR is targeted for the next major release labels Oct 17, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 17, 2018

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 17, 2018
@josephperrott
josephperrott merged commit 183df8f into angular:masterOct 17, 2018
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: majorThis PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion@jelbourn@googlebot@josephperrott