Uh oh!
There was an error while loading. Please reload this page.
refactor(overlay): convert fullscreen overlay container e2e tests into unit tests - #13657
Merged
Merged
Conversation
devversion
approved these changes
Oct 17, 2018
| // Provide a (very limited) stub for the document. This is the most practical solution for | ||
| // now since we only hit a handful of Document APIs. If we end up having to add more | ||
| // stubs here, we should reconsider whether to use a Proxy instead. Avoiding a proxy for | ||
| // now since isn't supported on IE. See: |
…o unit tests Converts the e2e tests for the `FullscreenOverlayContainer` into unit tests since we can't trigger the fullscreen API in Chrome Headless.
crisbetoforce-pushed
the
fullscreen-unit-tests
branch
from
October 17, 2018 20:26
f494fb8 to
9ba0986CompareThis issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the e2e tests for the
FullscreenOverlayContainerinto unit tests since we can't trigger the fullscreen API in Chrome Headless.