Uh oh!
There was an error while loading. Please reload this page.
build: test material with bazel - #13670
Conversation
f6bc578 to
c5bf364CompareUh oh!
There was an error while loading. Please reload this page.
c5bf364 to
0c2fa8cCompare| ) | ||
| def ng_web_test_suite(deps = [], srcs = [], static_css = [], **kwargs): | ||
| def ng_web_test_suite(deps = [], srcs = [], static_css = [], prebuilt_theme = False, |
There was a problem hiding this comment.
Ah, I wasn't clear in out conversation- the prebuilt_theme attribute should just be removed completely.
There was a problem hiding this comment.
So just manually specify the theme for each target?
We cannot always add a theme if this macro is being used because the CDK tests also use the same macro.
There was a problem hiding this comment.
I was thinking that it would be fine to include it for the cdk tests too; they shouldn't be affected either way.
There was a problem hiding this comment.
I see, it's still feels a bit odd to have CDK tests use a prebuilt theme, but I agree that this makes it consistent to how the tests run w/ Gulp + themes shouldn't affect the CDK tests.
Done! please have another look 😄
* Supports testing `src/lib` with Bazel.
0c2fa8c to
1d9c58fCompare* build: test material with bazel * Supports testing `src/lib` with Bazel. * Add prebuilt theme to all Material tests * Always include prebuilt theme. Rebase changes for paginator spec
* build: test material with bazel * Supports testing `src/lib` with Bazel. * Add prebuilt theme to all Material tests * Always include prebuilt theme. Rebase changes for paginator spec
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
src/libwith Bazel.Note: Very few tests had to be updated because w/ Bazel the HTML files are not minified and therefore there could be some whitespace (even with
preserveWhitespace=falseby default).