Skip to content

build: exported scss files missing in CDK - #13679

Merged
josephperrott merged 1 commit into
angular:masterfrom
devversion:build/cdk-exported-scss-files-missing
Oct 19, 2018
Merged

build: exported scss files missing in CDK#13679
josephperrott merged 1 commit into
angular:masterfrom
devversion:build/cdk-exported-scss-files-missing

Conversation

@devversion

@devversiondevversion commented Oct 19, 2018

Copy link
Copy Markdown
Member
  • SCSS source files such as _overlay.scss, _a11y.scss have not been published since 7.0.0-beta.0. This happens because we no longer copy SCSS source files to the package output in favor of faster live-reloading.

@devversiondevversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 19, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 19, 2018

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbetocrisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 19, 2018
const styleGlobs = [
join(buildPackage.sourceDir, '**/*.css'),
join(buildPackage.sourceDir, '**/_*.scss'),
]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

@devversion
devversionforce-pushed the build/cdk-exported-scss-files-missing branch from 2acc9f3 to 875c52fCompareOctober 19, 2018 07:06
* SCSS source files such as `_overlay.scss`, `_a11y.scss` have not been published since `7.0.0-beta.0`. This happens because we no longer copied SCSS source files to the package output in favor of faster live-reloading.
@devversion
devversionforce-pushed the build/cdk-exported-scss-files-missing branch from 875c52f to b5118d2CompareOctober 19, 2018 07:11
@josephperrott
josephperrott merged commit 16098a7 into angular:masterOct 19, 2018
@devversion
devversion deleted the build/cdk-exported-scss-files-missing branch October 19, 2018 14:29
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@devversion@crisbeto@jelbourn@googlebot@josephperrott