Skip to content

build: run browserstack on circleci - #13749

Merged
mmalerba merged 1 commit into
angular:masterfrom
devversion:build/run-browserstack-circle
Oct 24, 2018
Merged

build: run browserstack on circleci#13749
mmalerba merged 1 commit into
angular:masterfrom
devversion:build/run-browserstack-circle

Conversation

@devversion

Copy link
Copy Markdown
Member

No description provided.

@devversion

Copy link
Copy Markdown
MemberAuthor

This is blocked for now because due to the GitHub issues, CircleCI is not able to run jobs for this PR.

@devversiondevversion added blocked This issue is blocked by some external factor, such as a prerequisite PR cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release pr: merge safe labels Oct 22, 2018
Comment thread.circleci/config.yml Outdated
unit_tests:
jobs:
- tests_local_browsers
- browserstack_tests

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do tests_browserstack. So the naming convention is consistent

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Will update that

@googlebot

This comment has been minimized.

@googlebotgooglebot removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 22, 2018
@devversiondevversion added the in progress This issue is currently in progress label Oct 22, 2018
@josephperrottjosephperrott added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 22, 2018
@josephperrott

Copy link
Copy Markdown
Member

CLA confirmed manually

@devversion
devversionforce-pushed the build/run-browserstack-circle branch 5 times, most recently from 4d15d1d to 7ac57b0CompareOctober 23, 2018 07:04
@devversion
devversionforce-pushed the build/run-browserstack-circle branch from e35a2d7 to 0b9c94cCompareOctober 23, 2018 07:41
@devversiondevversion removed blocked This issue is blocked by some external factor, such as a prerequisite PR in progress This issue is currently in progress labels Oct 23, 2018

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 24, 2018
@mmalerba
mmalerba merged commit b30ec56 into angular:masterOct 24, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@devversion@googlebot@josephperrott@jelbourn@mmalerba