Skip to content

fix(stepper): selector assuming that there will always be a dir attribute - #13751

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:13741/stepper-ltr-selector
Oct 23, 2018
Merged

fix(stepper): selector assuming that there will always be a dir attribute#13751
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:13741/stepper-ltr-selector

Conversation

@crisbeto

@crisbetocrisbeto commented Oct 22, 2018

Copy link
Copy Markdown
Member

One of the selectors in the step header assumes that there will be at least one parent with a dir="ltr" or dir="rtl". These changes rework it to have LTR as the base.

Fixes#13741.

@crisbeto
fix(stepper): selector assuming that there will always be a dir attri…
b540104
…bute
One of the selectors in the step header assumes that there will be at least one parent with a `dir="ltr"` or `dir="rtl"`. These changes rework it to have LTR as the base.
Fixesangular#13741.
@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Oct 22, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 22, 2018
@mmalerbammalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 22, 2018
@mmalerba
mmalerba merged commit d5f0f0f into angular:masterOct 23, 2018
mmalerba pushed a commit that referenced this pull request Oct 26, 2018
@crisbeto@mmalerba
fix(stepper): selector assuming that there will always be a dir attri…
576118e
…bute (#13751)
One of the selectors in the step header assumes that there will be at least one parent with a `dir="ltr"` or `dir="rtl"`. These changes rework it to have LTR as the base.
Fixes#13741.
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 9, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerbammalerbaAwaiting requested review from mmalerba

Assignees

@mmalerbammalerba

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(stepper) labelPosition wrong GUI if 'dir' attribute is missing

3 participants

@crisbeto@googlebot@mmalerba