Skip to content

fix(checkbox): disabled property not being coerced - #13755

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:13739/checkbox-disabled-coercion
Oct 23, 2018
Merged

fix(checkbox): disabled property not being coerced#13755
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:13739/checkbox-disabled-coercion

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Fixes the disabled property not being coerced like all the other components.

Fixes#13739.

@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Oct 22, 2018
@crisbeto
crisbetoforce-pushed the 13739/checkbox-disabled-coercion branch from 67baa7d to 6391317CompareOctober 22, 2018 20:23
Fixes the `disabled` property not being coerced like all the other components.
Fixesangular#13739.
@crisbeto
crisbetoforce-pushed the 13739/checkbox-disabled-coercion branch from 6391317 to 4bdbf44CompareOctober 22, 2018 20:23
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 22, 2018

@devversiondevversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversiondevversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 23, 2018
@mmalerba
mmalerba merged commit e5fe34c into angular:masterOct 23, 2018
mmalerba pushed a commit that referenced this pull request Oct 26, 2018
Fixes the `disabled` property not being coerced like all the other components.
Fixes#13739.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

disabled input on mat-checkbox not behaving like with other components

6 participants

@crisbeto@devversion@josephperrott@jelbourn@googlebot@mmalerba