Skip to content

docs(drag-drop): add doc section and live example for customizing the placeholder - #13777

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:13765/drag-drop-placeholder-docs
Oct 24, 2018
Merged

docs(drag-drop): add doc section and live example for customizing the placeholder#13777
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:13765/drag-drop-placeholder-docs

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Adds a paragraph about the cdkDragPlaceholder and sets up a live example.

Fixes#13765.

… placeholder
Adds a paragraph about the `cdkDragPlaceholder` and sets up a live example.
Fixesangular#13765.
@crisbetocrisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 23, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 23, 2018
@jimitndiaye

jimitndiaye commented Oct 24, 2018

Copy link
Copy Markdown
Contributor

@crisbeto Might I suggest expanding the example to be similar to the ToDo connected sorting example with two lists (one of which is not a cdkDropList)? The reason I bring that up is that because the cdkDragPlaceholder is defined on the ckdDrag rather than the cdkDropList you'd need to have a second cdkDragPlaceholder on the drag items of the second list even though the placeholder will be shown in the first list. This is not obvious behavior (at least to me) and probably needs to be emphasized.

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 24, 2018
@mmalerba
mmalerba merged commit 530c0eb into angular:masterOct 24, 2018
mmalerba pushed a commit that referenced this pull request Oct 26, 2018
… placeholder (#13777)
Adds a paragraph about the `cdkDragPlaceholder` and sets up a live example.
Fixes#13765.
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
… placeholder (angular#13777)
Adds a paragraph about the `cdkDragPlaceholder` and sets up a live example.
Fixesangular#13765.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for drop target placeholder to CDK drag and drop

5 participants

@crisbeto@jimitndiaye@jelbourn@googlebot@mmalerba