Skip to content

refactor(schematics): group ng-generate schematics in folder - #13794

Merged
mmalerba merged 1 commit into
angular:masterfrom
devversion:refactor/schematics-group-ng-generate-folder
Oct 24, 2018
Merged

refactor(schematics): group ng-generate schematics in folder#13794
mmalerba merged 1 commit into
angular:masterfrom
devversion:refactor/schematics-group-ng-generate-folder

Conversation

@devversion

Copy link
Copy Markdown
Member
  • Similarly to the CDK schematics, schematics that can be (ng-)generated should be grouped into its own directory. This cleans up the schematics folder and makes it clear where each schematic lives.
  • Removes a tslint ignore comment in a schematic test.

image

* Similarly to the CDK schematics, schematics that can be (ng-)`generated` should be grouped into its own directory. This cleans up the schematics folder and makes it clear where each schematic lives.
* Removes a tslint ignore comment in a schematic test.
@devversiondevversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 24, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 24, 2018

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 24, 2018
@mmalerba
mmalerba merged commit f5d42cd into angular:masterOct 24, 2018
mmalerba pushed a commit that referenced this pull request Oct 26, 2018
* Similarly to the CDK schematics, schematics that can be (ng-)`generated` should be grouped into its own directory. This cleans up the schematics folder and makes it clear where each schematic lives.
* Removes a tslint ignore comment in a schematic test.
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
…#13794)
* Similarly to the CDK schematics, schematics that can be (ng-)`generated` should be grouped into its own directory. This cleans up the schematics folder and makes it clear where each schematic lives.
* Removes a tslint ignore comment in a schematic test.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion@jelbourn@googlebot@mmalerba