Skip to content

docs: add example for cdk platform - #13821

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:platform-example
Oct 29, 2018
Merged

docs: add example for cdk platform#13821
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:platform-example

Conversation

@crisbeto

@crisbetocrisbeto commented Oct 25, 2018

Copy link
Copy Markdown
Member

Since the overview for cdk/platform is pretty bare on the docs site at the moment, these changes add an example that illustrates how the utilities can be used.

@crisbeto
docs: add example for cdk platform
c77dcf8
Since the overview for `cdk/platform` is pretty bare on the docs site at the moment, these changes add an example that illustrates how the utilities can be used.
@crisbetocrisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 25, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 25, 2018
jelbourn
jelbourn approved these changes Oct 25, 2018
View reviewed changes

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 25, 2018
@ngbot

ngbotBot commented Oct 25, 2018

Copy link
Copy Markdown

I see that you just added the pr: merge ready label, but the following checks are still failing:
failure status "ci/circleci: e2e_tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

devversion
devversion approved these changes Oct 26, 2018
View reviewed changes

@devversiondevversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jelbourn
jelbourn merged commit ab5127b into angular:masterOct 29, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
@crisbeto@atscott
docs: add example for cdk platform (angular#13821)
0cfdb59
Since the overview for `cdk/platform` is pretty bare on the docs site at the moment, these changes add an example that illustrates how the utilities can be used.
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
@crisbeto@jelbourn
docs: add example for cdk platform (#13821)
2c8caa6
Since the overview for `cdk/platform` is pretty bare on the docs site at the moment, these changes add an example that illustrates how the utilities can be used.
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversiondevversiondevversion approved these changes
+1 more reviewer
@jelbournjelbournjelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jelbournjelbourn

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto@jelbourn@devversion@googlebot