Skip to content

build: test remaining packages with bazel - #13844

Merged
jelbourn merged 1 commit into
angular:masterfrom
devversion:build/build-remaining-packages-with-bzl
Oct 29, 2018
Merged

build: test remaining packages with bazel#13844
jelbourn merged 1 commit into
angular:masterfrom
devversion:build/build-remaining-packages-with-bzl

Conversation

@devversion

Copy link
Copy Markdown
Member
  • Sets up Bazel build and testing for the cdk-experimental, material-experimental and material-moment-adapter package.

@devversiondevversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 27, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 27, 2018
* Sets up Bazel build and testing for the `cdk-experimental`, `material-experimental` and `material-moment-adapter` package.
@devversion
devversionforce-pushed the build/build-remaining-packages-with-bzl branch from bdbe25c to e744ceeCompareOctober 27, 2018 18:10
"//src/cdk/scrolling",
"//src/cdk/testing",
"@rxjs",
":scrolling",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this ng_test_library you rely on scrolling to provide all of the cdk module build rules, but in dialog's ng_test_library you require them all in both places. Is there a reason we don't do them the same way?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests in cdk-experimental/scrolling only directly depend on cdk/scrolling whereas the experimental dialog test imports all of those packages directly.

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 29, 2018
@jelbourn
jelbourn merged commit a479366 into angular:masterOct 29, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
* Sets up Bazel build and testing for the `cdk-experimental`, `material-experimental` and `material-moment-adapter` package.
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
* Sets up Bazel build and testing for the `cdk-experimental`, `material-experimental` and `material-moment-adapter` package.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion@jelbourn@josephperrott@googlebot