Revert "fix: workaround for es2015 inheritance not always working (#1…

[jelbourn]

…3834)"

This reverts commit a22a9fa.

This change caused a new issue where Closure Compiler was not able to do
dead-code elimination due to the function call with unknown side
effects.

[devversion]

@jelbourn Hmm going forward with this, I'm not sure if it's even worth keeping the workaround at all.

The way it will be after the revert (without my new changes), it's practically not helping and just causes even more exceptions than before (in case the ctorParameters is not a function; which is often the case).

We definitely need to solve the Closure issue, and I can't think of a way to mark the function for inheriting as side effect free (google/closure-compiler#2256). That being said, we should probably remove the workaround completely and wait for Ivy. It's not an issue from Material, rather from Angular.

[devversion]

Also considering that angular/angular#24014 is finally merge ready as well, it might be just the best to get rid of the workaround completely. I can update this PR if you don't find time for it.

[jelbourn]

We need to revert it first to unblock syncing into Google and then we can explore other approaches

[devversion]

Sounds good. Should we chat on Slack about the final solution? I'd vote for removing.

[jelbourn]

@devversion yeah, let's discuss it in more detail

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}