Skip to content

Revert "fix(dialog,bottom-sheet): enter animation blocking child anim… - #14017

Merged
vivian-hu-zz merged 1 commit into
angular:masterfrom
jelbourn:dialog-revert
Nov 7, 2018
Merged

Revert "fix(dialog,bottom-sheet): enter animation blocking child anim…#14017
vivian-hu-zz merged 1 commit into
angular:masterfrom
jelbourn:dialog-revert

Conversation

@jelbourn

@jelbournjelbourn commented Nov 7, 2018

Copy link
Copy Markdown
Contributor

…ations (#13888)"

This reverts commit 235add9.

This change broke an app inside of Google where tabs appear inside of a
dialog. The tabs get stuck in a weird frozen animation state.

@jelbourn
Revert "fix(dialog,bottom-sheet): enter animation blocking child anim…
442e708
…ations (angular#13888)"
This reverts commit 235add9.
This change broke an app inside of Google where tabs appear inside of a
dialog. The tabs get stuck in a weird frozen animation state.
@jelbournjelbourn added the target: patch This PR is targeted for the next patch release label Nov 7, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 7, 2018
vivian-hu-zz
vivian-hu-zz approved these changes Nov 7, 2018
View reviewed changes

@vivian-hu-zzvivian-hu-zz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivian-hu-zz
vivian-hu-zz merged commit d50b9f2 into angular:masterNov 7, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@jelbournVivian Hu
Revert "fix(dialog,bottom-sheet): enter animation blocking child anim…
53c9649
…ations (#13888)" (#14017)
This reverts commit 235add9.
This change broke an app inside of Google where tabs appear inside of a
dialog. The tabs get stuck in a weird frozen animation state.
@virtuoushubvirtuoushub mentioned this pull request Nov 28, 2018
Closed
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbetocrisbetoAwaiting requested review from crisbeto
@josephperrottjosephperrottAwaiting requested review from josephperrott
1 more reviewer
@vivian-hu-zzvivian-hu-zzvivian-hu-zz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jelbourn@vivian-hu-zz@googlebot