build: remove es2015 workaround

[devversion]

With two commits (2adced1 and a22a9fa), we recently tried to add a workaround for an Angular bug that causes Angular Material to not work w/ ES2015.

The workaround technically worked but had to be partially reverted because Google Closure compiler was no longer able to remove unused classes (due to a function with side-effects that modified the actual component metadata).

Since the workaround (in the state it is right now) is not helping at all and a fix will land with Angular v7.1.0 (angular/angular@95743e3), we are removing the workaround completely.

Closes#12760

[jelbourn]

LGTM

[jmpreston]

NOT FIXED in 7.1.0. TS 3.1.6. See issue #14100

[devversion]

@svstartuplab As mentioned in the PR description. This is not a problem from the Angular Material side, so we cannot do much about it. Based on angular/angular@95743e3, this issue should be fixed if you use Angular Material 7.1.0and Angular 7.1.0

[jmpreston]

I just upgraded to 7.1.0 from 6 a few days ago for Angular and Material and the problem started. I think I'm using the latest versions of everything.

[devversion]

Angular Material v7.1.0 just came out yesterday. Can you please retry? Thanks!

Also making sure that you are using Angular 7.1.0 as well.

[jmpreston]

As mentioned, I am using 7.1.0. From npm view:

@angular/material@7.1.0 | MIT | deps: 1 | versions: 101
Angular Material
https://github.com/angular/material2#readme
keywords: angular, material, material design, components
dist
.tarball: https://registry.npmjs.org/@angular/material/-/material-7.1.0.tgz
.shasum: 441f2d03a97a1fa35546b61dcde86db34f0f5efc
.integrity: sha512-bgotNpSfGLjNZ1AcTyhs6XS7trF4I7UHwQmfa0l8y3Gf9plwErPDfQe2XqnayRyG9nTwHj9f1lQ45X5mr3/0/A==
.unpackedSize: 20.4 MB
dependencies:
tslib: ^1.7.1 maintainers:
- angular <devops+npm@angular.io>
dist-tags:
latest: 7.1.0 next: 7.0.0-rc.2 

[devversion]

Okay, assuming that you use Angular v7.1.0 and Angular Material v7.1.0, what's your exact exception?

In our code, the ctorParameters workaround is completely gone, so I'm wondering what your exception looks like?

[devversion]

If your exception is Uncaught TypeError: ctorParameters.map is not a function, then this means that you somehow still use an old version.

Otherwise if there is a different exception, then this is an Angular issue that should be reported on here

[jmpreston]

1. The above info comes from: npm view @angular/material

2. import { MatTableModule } from '@angular/material/table';

I'm no expert but I seem to be using the latest version.

3. npm view @angular/material/table version === 0.0.1

[devversion]

npm view @angular/material checks the online registry, so that's not necessarily the version you have installed. Can you please do the following:

1. Run npm ls @angular/core and post output here
2. Run npm ls @angular/material and post output here
3. Write the error message here in the issue.

Thanks.

[jmpreston]

@angular/core@7.0.3

@angular/material@7.0.3

From package.json:

"@angular/core": "^7.0.3",
"@angular/material": "^7.0.3",

So something happened in the upgrade and it updated the registry but not the packages?

[devversion]

Yeah, so that shows that you didn't update Angular and Angular Material to the latest version. Do you have a lock file? probably run npm update (https://docs.npmjs.com/cli/update)

Sorry, I cannot help more with the issue. Please consider asking on Stackoverflow. Thanks for the feedback though.

[jmpreston]

Thank you. I did use both npm install and npm update. Just another computer mystery :-)

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}