Skip to content

feat(drag-drop): indicate in dropped event whether item was dropped outside of container - #14140

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:14136/drag-drop-out-of-container
Nov 28, 2018
Merged

feat(drag-drop): indicate in dropped event whether item was dropped outside of container#14140
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:14136/drag-drop-out-of-container

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Adds an extra flag on the CdkDragDrop event that indicates whether the user's pointer was over the container when they dropped an item.

Fixes#14136.

@crisbetocrisbeto added the target: minor This PR is targeted for the next minor release label Nov 14, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 14, 2018
@ngbot

ngbotBot commented Nov 14, 2018

Copy link
Copy Markdown

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
crisbetoforce-pushed the 14136/drag-drop-out-of-container branch from 4347f22 to ff41c63CompareNovember 15, 2018 06:00
@crisbetocrisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Nov 15, 2018
@jelbourn

Copy link
Copy Markdown
Contributor

@crisbeto API gold needs to be updated.

…utside of container
Adds an extra flag on the `CdkDragDrop` event that indicates whether the user's pointer was over the container when they dropped an item.
Fixesangular#14136.
@crisbeto
crisbetoforce-pushed the 14136/drag-drop-out-of-container branch from ff41c63 to 0939700CompareNovember 27, 2018 18:25
@crisbeto

Copy link
Copy Markdown
MemberAuthor

@jelbourn goldens have been updated.

@jelbourn
jelbourn merged commit 42de6a2 into angular:masterNov 28, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
…utside of container (angular#14140)
Adds an extra flag on the `CdkDragDrop` event that indicates whether the user's pointer was over the container when they dropped an item.
Fixesangular#14136.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: minorThis PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(@angular/cdk/cdkDrag): cdkDragEnded out of a container

3 participants

@crisbeto@jelbourn@googlebot