Fix/dynamically changing autocomplete

[thomaspink]

fixes#13812

This PR is a reopened copy of #13814 because of an accidental merge to master despite breaking some internal google apps.

@mmalerba can you provide the error or some information why this PR did break these apps?

[crisbeto]

LGTM. @thomaspink can you rename the PR to the same as the original one?

[thomaspink]

@crisbeto Sure; Done

[mmalerba]

@thomaspink I think they had some custom logic to show loading spinners and things. It's probably their app that needs to be updated, not this PR.

[thomaspink]

@mmalerba Good to know. thanks for the investigation.

[thomaspink]

@crisbeto What do i have to do solve the "commit message fixup"? Squash the commits?

[crisbeto]

If you hover over the label, it says that it's for the caretaker.

[vivian-hu-zz]

Change commit message to fix(autocomplete): not updating if panel is changed after init.

[ngbot]

Hi @thomaspink! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

[ngbot]

Hi @thomaspink! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

[thomaspink]

@crisbeto after rebasing the api check fails. There are only minor differences between the golden file and the changed one in the PR.

autocomplete.ts

• added internal _portal property
• added _viewContainerRef: ViewContainerRef as a private in constructor
• added ngAfterViewInit method

autocomplete-trigger.ts

• removed _viewContainerRef: ViewContainerRef from the constructor

Is there something i have to change/do there?

[crisbeto]

You can run bazel run //tools/public_api_guard:lib_autocomplete_api.accept to update the golden file.

[MohammadRafik]

@thomaspink this PR has fallen out of date, could you please rebase this PR?

[andrewseguin]

This PR is being closed due to inactivity and needing rebase for a very long time. Please feel free to re-open the change after rebasing and we can take another look at getting it merged.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}