Skip to content

fix(drag-drop): prevent text selection while dragging on Safari - #14405

Merged
vivian-hu-zz merged 1 commit into
angular:masterfrom
crisbeto:14403/safari-text-selection
Dec 12, 2018
Merged

fix(drag-drop): prevent text selection while dragging on Safari#14405
vivian-hu-zz merged 1 commit into
angular:masterfrom
crisbeto:14403/safari-text-selection

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Fixes being able to select text while dragging an item on Safari.

Fixes#14403.

@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Dec 6, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 6, 2018

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 6, 2018
Fixes being able to select text while dragging an item on Safari.
Fixesangular#14403.
@crisbeto
crisbetoforce-pushed the 14403/safari-text-selection branch from 95e1721 to 85f04e0CompareDecember 7, 2018 21:40
@vivian-hu-zz
vivian-hu-zz merged commit 220e388 into angular:masterDec 12, 2018
vivian-hu-zz added a commit that referenced this pull request Dec 13, 2018
vivian-hu-zz added a commit that referenced this pull request Dec 13, 2018
…correctly if the floating label is disabled" (#14505)
* Revert "Revert "fix(snack-bar): announcing same message twice to screen readers" (#14494)"
This reverts commit e9466a4.
* Revert "Revert "fix(dialog,bottom-sheet): invert backdrop color on dark themes" (#14492)"
This reverts commit 3eb7e9c.
* Revert "Revert "fix(menu): allow text wrapping in menu items" (#14493)"
This reverts commit a3da8d2.
* Revert "build: update nodejs bazel rules (#14466)"
This reverts commit a3fef46.
* Revert "docs(form-field): native select reset values not working in examples (#14236)"
This reverts commit 97f52c0.
* Revert "fix(menu): allow text wrapping in menu items (#11430)"
This reverts commit 3661abe.
* Revert "fix(dialog,bottom-sheet): invert backdrop color on dark themes (#13065)"
This reverts commit fe96f38.
* Revert "build: replace deprecated tslint rule with compiler option (#13186)"
This reverts commit 5dfa45f.
* Revert "fix(snack-bar): announcing same message twice to screen readers (#13298)"
This reverts commit 3fb4b23.
* Revert "feat(drag-drop): allow entire group of drop lists to be disabled (#14179)"
This reverts commit 94e76de.
* Revert "fix(drag-drop): prevent text selection while dragging on Safari (#14405)"
This reverts commit 220e388.
* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#14414)"
This reverts commit 53d2b58.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
…lar#14405)
Fixes being able to select text while dragging an item on Safari.
Fixesangular#14403.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
…correctly if the floating label is disabled" (angular#14505)
* Revert "Revert "fix(snack-bar): announcing same message twice to screen readers" (angular#14494)"
This reverts commit e9466a4.
* Revert "Revert "fix(dialog,bottom-sheet): invert backdrop color on dark themes" (angular#14492)"
This reverts commit 3eb7e9c.
* Revert "Revert "fix(menu): allow text wrapping in menu items" (angular#14493)"
This reverts commit a3da8d2.
* Revert "build: update nodejs bazel rules (angular#14466)"
This reverts commit a3fef46.
* Revert "docs(form-field): native select reset values not working in examples (angular#14236)"
This reverts commit 97f52c0.
* Revert "fix(menu): allow text wrapping in menu items (angular#11430)"
This reverts commit 3661abe.
* Revert "fix(dialog,bottom-sheet): invert backdrop color on dark themes (angular#13065)"
This reverts commit fe96f38.
* Revert "build: replace deprecated tslint rule with compiler option (angular#13186)"
This reverts commit 5dfa45f.
* Revert "fix(snack-bar): announcing same message twice to screen readers (angular#13298)"
This reverts commit 3fb4b23.
* Revert "feat(drag-drop): allow entire group of drop lists to be disabled (angular#14179)"
This reverts commit 94e76de.
* Revert "fix(drag-drop): prevent text selection while dragging on Safari (angular#14405)"
This reverts commit 220e388.
* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (angular#14414)"
This reverts commit 53d2b58.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(drag-drop): Safari selects text on drag

4 participants

@crisbeto@jelbourn@googlebot@vivian-hu-zz