Uh oh!
There was an error while loading. Please reload this page.
build: fix e2e tests failing due to chromedriver release (#14461) - #14475
Merged
Conversation
Apparently the webdriver-manager always uses the _latest_ version of the chromedriver. This is problematic because the CI does not always use the latest chrome version that _works_ with the chromedriver from `webdriver-manager`. In order to fix this, we lock the webdriver manager version to a specific version. Similarly to how it's done for `angular/angular`. Note that this also restricts which Chrome versions can be run locally with the e2e tests, but the chromedriver range seems to always cover at least the latest two versions (which works for us)
devversion
commented
Dec 11, 2018
MemberAuthor
Caretaker note: Only targetting patch because the one that landed in master does not apply cleanly. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently the webdriver-manager always uses the latest version of the chromedriver. This is problematic because the CI does not always use the latest chrome version that works with the chromedriver from
webdriver-manager.In order to fix this, we lock the webdriver manager version to a specific version. Similarly to how it's done for
angular/angular.Note that this also restricts which Chrome versions can be run locally with the e2e tests, but the chromedriver range seems to always cover at least the latest two versions (which works for us)