Skip to content

fix(dialog,bottom-sheet): invert backdrop color on dark themes - #14502

Closed
crisbeto wants to merge 1 commit into
angular:mainfrom
crisbeto:dialog-invert-backdrop-resubmit
Closed

fix(dialog,bottom-sheet): invert backdrop color on dark themes#14502
crisbeto wants to merge 1 commit into
angular:mainfrom
crisbeto:dialog-invert-backdrop-resubmit

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Similarly to how we handle the sidenav backdrop and ripples, these changes invert the color for the dialog and bottom sheet backdrops in dark themes.

Note: this is a resubmit of #13065.

@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Dec 13, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 13, 2018
@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 13, 2018
@ngbot

ngbotBot commented Dec 13, 2018

Copy link
Copy Markdown

I see that you just added the pr: merge ready label, but the following checks are still failing:
failure status "ci/circleci: tests_saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto
crisbetoforce-pushed the dialog-invert-backdrop-resubmit branch from badb974 to f61d2dfCompareDecember 17, 2018 21:55
@jelbourn

Copy link
Copy Markdown
Contributor

@crisbeto it looks like this is changing the backdrop color for light themes as well, which is causing a lot of screenshot diffs

@crisbeto
crisbetoforce-pushed the dialog-invert-backdrop-resubmit branch from f61d2df to 6e94a4bCompareDecember 28, 2018 15:54
@mmalerbammalerba removed the aaa label Apr 25, 2019
Similarly to how we handle the sidenav backdrop and ripples, these changes invert the color for the dialog and bottom sheet backdrops in dark themes.
@crisbeto
crisbetoforce-pushed the dialog-invert-backdrop-resubmit branch from 6e94a4b to 42e1961CompareJune 19, 2019 20:39
@mmalerbammalerba removed the lgtm label Jul 31, 2020
@andrewseguinandrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 29, 2021
@josephperrottjosephperrott added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed needs rebase labels Nov 16, 2022
@crisbeto

Copy link
Copy Markdown
MemberAuthor

AFAIK this isn't in the spec. Closing.

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Mar 30, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanupThe PR is in need of cleanup, either due to needing a rebase or in response to comments from reviewsaction: mergeThe PR is ready for merge by the caretakertarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@crisbeto@jelbourn@googlebot@josephperrott@mmalerba@andrewseguin@vivian-hu-zz