Uh oh!
There was an error while loading. Please reload this page.
fix(dialog,bottom-sheet): invert backdrop color on dark themes - #14502
Closed
crisbeto wants to merge 1 commit into
Closed
fix(dialog,bottom-sheet): invert backdrop color on dark themes#14502crisbeto wants to merge 1 commit into
crisbeto wants to merge 1 commit into
Conversation
crisbetoforce-pushed
the
dialog-invert-backdrop-resubmit
branch
from
December 17, 2018 21:55
badb974 to
f61d2dfComparejelbourn
commented
Dec 19, 2018
Contributor
@crisbeto it looks like this is changing the backdrop color for light themes as well, which is causing a lot of screenshot diffs |
crisbetoforce-pushed
the
dialog-invert-backdrop-resubmit
branch
from
December 28, 2018 15:54
f61d2df to
6e94a4bCompareSimilarly to how we handle the sidenav backdrop and ripples, these changes invert the color for the dialog and bottom sheet backdrops in dark themes.
crisbetoforce-pushed
the
dialog-invert-backdrop-resubmit
branch
from
June 19, 2019 20:39
6e94a4b to
42e1961Comparecrisbeto
commented
Feb 28, 2024
MemberAuthor
AFAIK this isn't in the spec. Closing. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Similarly to how we handle the sidenav backdrop and ripples, these changes invert the color for the dialog and bottom sheet backdrops in dark themes.
Note: this is a resubmit of #13065.