Uh oh!
There was an error while loading. Please reload this page.
fix(snack-bar): announcing same message twice to screen readers - #14504
Merged
andrewseguin merged 1 commit intoJul 14, 2020
Merged
Conversation
crisbetoforce-pushed
the
snack-bar-multi-announcement-resubmit
branch
from
July 22, 2019 21:15
54e884d to
bea6537CompareCurrently we have `role="alert"` on the snack bar which will cause screen readers to announce the message automatically. On top of it, we also use the `LiveAnnouncer` to announce the same message, if the consumer hasn't set one. These changes clear the `announcementMessage` if it's the same as the main message.
crisbetoforce-pushed
the
snack-bar-multi-announcement-resubmit
branch
from
June 11, 2020 20:12
bea6537 to
4660c93Compareandrewseguin pushed a commit
that referenced
this pull request
Jul 14, 2020
Currently we have `role="alert"` on the snack bar which will cause screen readers to announce the message automatically. On top of it, we also use the `LiveAnnouncer` to announce the same message, if the consumer hasn't set one. These changes clear the `announcementMessage` if it's the same as the main message.
ngwattcos pushed a commit
to ngwattcos/components
that referenced
this pull request
Jul 20, 2020
…lar#14504) Currently we have `role="alert"` on the snack bar which will cause screen readers to announce the message automatically. On top of it, we also use the `LiveAnnouncer` to announce the same message, if the consumer hasn't set one. These changes clear the `announcementMessage` if it's the same as the main message.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have
role="alert"on the snack bar which will cause screen readers to announce the message automatically. On top of it, we also use theLiveAnnouncerto announce the same message, if the consumer hasn't set one. These changes clear theannouncementMessageif it's the same as the main message.Note: this is a resubmit of #13298.
Fixes#14825.