Skip to content

docs(select): update live examples to use labels - #15095

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:15022/select-examples-label
Feb 20, 2019
Merged

docs(select): update live examples to use labels#15095
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:15022/select-examples-label

Conversation

@crisbeto

Copy link
Copy Markdown
Member
  • Fixes a few examples that didn't have labels for the native select.
  • Switches all of the examples to use the mat-label, instead of a placeholder.

Fixes#15022.

* Fixes a few examples that didn't have labels for the native select.
* Switches all of the examples to use the `mat-label`, instead of a `placeholder`.
Fixesangular#15022.
@crisbetocrisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 5, 2019
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 5, 2019

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker labels Feb 20, 2019
@jelbourn
jelbourn merged commit 4021929 into angular:masterFeb 20, 2019
jelbourn pushed a commit that referenced this pull request Feb 20, 2019
* Fixes a few examples that didn't have labels for the native select.
* Switches all of the examples to use the `mat-label`, instead of a `placeholder`.
Fixes#15022.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementdocsThis issue is related to documentationtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native select examples are missing programatic labels

3 participants

@crisbeto@jelbourn@googlebot