Skip to content

fix(input): input not focused on click in IE if clicked outside of the native input element - #15108

Merged
jelbourn merged 1 commit into
angular:masterfrom
macjohnny:patch-1
Feb 12, 2019
Merged

fix(input): input not focused on click in IE if clicked outside of the native input element#15108
jelbourn merged 1 commit into
angular:masterfrom
macjohnny:patch-1

Conversation

@macjohnny

@macjohnnymacjohnny commented Feb 7, 2019

Copy link
Copy Markdown
Contributor

fixes#15093

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 7, 2019
crisbeto
crisbeto reviewed Feb 7, 2019
View reviewed changes
Comment threadsrc/lib/input/input.ts Outdated
@macjohnny

macjohnny commented Feb 8, 2019

Copy link
Copy Markdown
ContributorAuthor

in the dev-app, this can be tested with the "Only placeholder" input in the "Floating labels" section

@macjohnnymacjohnny mentioned this pull request Feb 8, 2019
Closed
crisbeto
crisbeto approved these changes Feb 8, 2019
View reviewed changes

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crisbeto
crisbeto reviewed Feb 8, 2019
View reviewed changes
Comment threadsrc/lib/form-field/form-field-input.scss
@crisbetocrisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 8, 2019
@jelbournjelbourn added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Feb 12, 2019
jelbourn
jelbourn approved these changes Feb 12, 2019
View reviewed changes

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
jelbourn merged commit 2652532 into angular:masterFeb 12, 2019
@macjohnnymacjohnny mentioned this pull request Mar 22, 2019
Merged
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbetocrisbetocrisbeto approved these changes
@mmalerbammalerbaAwaiting requested review from mmalerba
+1 more reviewer
@jelbournjelbournjelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementmerge: fix commit messageWhen the PR is merged, rewrites/fixups of the commit messages are neededtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Input looks ready for input but does not have curosr

5 participants

@macjohnny@jelbourn@crisbeto@mmalerba@googlebot