Skip to content

Toggle buttons aria labels changes #14999 - #15114

Merged
jelbourn merged 4 commits into
angular:masterfrom
Suresh918:toggle-button-aria-lables
Feb 11, 2019
Merged

Toggle buttons aria labels changes #14999#15114
jelbourn merged 4 commits into
angular:masterfrom
Suresh918:toggle-button-aria-lables

Conversation

@Suresh918

@Suresh918Suresh918 commented Feb 7, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#14999

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 7, 2019
crisbeto
crisbeto reviewed Feb 7, 2019
View reviewed changes

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add "Fixes #14999" to the commit message? Otherwise the issue won't be closed when we merge the PR.

Comment threadsrc/material-examples/button-toggle-exclusive/button-toggle-exclusive-example.html Outdated
crisbeto
crisbeto approved these changes Feb 9, 2019
View reviewed changes

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbetocrisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 9, 2019
@jelbourn
jelbourn merged commit cb7d3b9 into angular:masterFeb 11, 2019
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbetocrisbetocrisbeto approved these changes
@jelbournjelbournAwaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Toggle buttons in the toggle button example are missing accessible names

4 participants

@Suresh918@jelbourn@crisbeto@googlebot