Skip to content

fix(bottom-sheet): focus trap not being attached when autoFocus is disabled - #15125

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:15119/bottom-sheet-focus-trap
Feb 12, 2019
Merged

fix(bottom-sheet): focus trap not being attached when autoFocus is disabled#15125
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:15119/bottom-sheet-focus-trap

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Fixes the bottom sheet container not creating a focus trap, if autoFocus is set to false.

Fixes#15119.

…sabled
Fixes the bottom sheet container not creating a focus trap, if `autoFocus` is set to `false`.
Fixesangular#15119.
@crisbetocrisbeto added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Feb 8, 2019
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 8, 2019
@mmalerbammalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 8, 2019
@jelbourn
jelbourn merged commit 3787695 into angular:masterFeb 12, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

AccessibilityThis issue is related to accessibility (a11y)action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bottom-sheet: focus trapping does not work unless autoFocus is true

4 participants

@crisbeto@mmalerba@jelbourn@googlebot