Skip to content

fix(docs): Icons in the toolbar example are missing alternative text … - #15128

Merged
jelbourn merged 2 commits into
angular:masterfrom
Suresh918:toolbar-icons-aria-lables
Feb 14, 2019
Merged

fix(docs): Icons in the toolbar example are missing alternative text …#15128
jelbourn merged 2 commits into
angular:masterfrom
Suresh918:toolbar-icons-aria-lables

Conversation

@Suresh918

@Suresh918Suresh918 commented Feb 8, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#15041

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 8, 2019
crisbeto
crisbeto reviewed Feb 10, 2019
View reviewed changes
Comment threadsrc/material-examples/toolbar-multirow/toolbar-multirow-example.html Outdated
<mat-icon class="example-icon">favorite</mat-icon>
<span class="cdk-visually-hidden">Example heart icon</span>
<mat-icon class="example-icon">delete</mat-icon>
<span class="cdk-visually-hidden">Example delete icon</span>

@crisbetocrisbetoFeb 10, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These labels should be set as an aria-label on the mat-icon, rather than a span next to it.

@Suresh918Suresh918Feb 14, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed as per your suggestion. Can you please check now

jelbourn
jelbourn approved these changes Feb 14, 2019
View reviewed changes

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think that this example needs some other improvements since the the toolbar is basically just a colored div, but that can be dealt with at some future date.

@jelbournjelbourn added pr: lgtm docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Feb 14, 2019
@jelbourn
jelbourn merged commit aff565a into angular:masterFeb 14, 2019
jelbourn pushed a commit that referenced this pull request Feb 20, 2019
@Suresh918@jelbourn
docs(toolbar): add aria-labels to icons in example (#15128)
e7d22b5
Fixes#15041
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbetocrisbetocrisbeto left review comments
+1 more reviewer
@jelbournjelbournjelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementdocsThis issue is related to documentationmerge: fix commit messageWhen the PR is merged, rewrites/fixups of the commit messages are neededtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Icons in the toolbar example are missing alternative text

4 participants

@Suresh918@jelbourn@crisbeto@googlebot