Uh oh!
There was an error while loading. Please reload this page.
fix: add dependency on @angular/forms - #15133
Merged
Merged
Conversation
devversion
requested changes
Feb 9, 2019
devversion
left a comment
Member
There was a problem hiding this comment.
I think we should make sure that ng add installs @angular/forms if it's not installed yet.
Adds `@angular/forms` to the list of dependencies, because there are around 10 Material components that are importing symbols from it. Fixesangular#15085.
crisbetoforce-pushed
the
15085/forms-dependency
branch
from
February 9, 2019 17:43
eed33d0 to
6219b23Comparecrisbeto
commented
Feb 9, 2019
MemberAuthor
Ah, totally forgot about the schematics. I've added it. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@angular/formsto the list of dependencies, because there are around 10 Material components that are importing symbols from it.Fixes#15085.