Skip to content

refactor(stepper): remove dependency on @angular/forms#15134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephperrott merged 1 commit into from
Mar 5, 2019
+12 −4
Merged

refactor(stepper): remove dependency on @angular/forms #15134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/cdk/stepper/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ ng_module(
deps = [
"@angular//packages/common",
"@angular//packages/core",
"@angular//packages/forms",
"@rxjs",
"@rxjs//operators",
"//src/cdk/a11y",
Expand Down
8 changes: 6 additions & 2 deletions src/cdk/stepper/stepper.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,7 +34,6 @@ import {
InjectionToken,
} from '@angular/core';
import {DOCUMENT} from '@angular/common';
import {AbstractControl} from '@angular/forms';
import {CdkStepLabel} from './step-label';
import {Observable, Subject, of as obaservableOf} from 'rxjs';
import {startWith, takeUntil} from 'rxjs/operators';
Expand DownExpand Up@@ -125,7 +124,12 @@ export class CdkStep implements OnChanges {
@ViewChild(TemplateRef) content: TemplateRef<any>;

/** The top level abstract control of the step. */
@Input() stepControl: AbstractControl;
@Input() stepControl: {
valid: boolean;
invalid: boolean;
pending: boolean;
reset: () => void;
};

/** Whether user has seen the expanded step content or not. */
interacted = false;
Expand Down
7 changes: 6 additions & 1 deletion tools/public_api_guard/cdk/stepper.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,12 @@ export declare class CdkStep implements OnChanges {
label: string;
optional: boolean;
state: StepState;
stepControl: AbstractControl;
stepControl: {
valid: boolean;
invalid: boolean;
pending: boolean;
reset: () => void;
};
stepLabel: CdkStepLabel;
constructor(_stepper: CdkStepper, stepperOptions?: StepperOptions);
ngOnChanges(): void;
Expand Down