Skip to content

docs(stepper): update non-default boolean for editable prop - #15161

Merged
jelbourn merged 1 commit into
angular:masterfrom
cbejensen:editable-boolean
Feb 13, 2019
Merged

docs(stepper): update non-default boolean for editable prop#15161
jelbourn merged 1 commit into
angular:masterfrom
cbejensen:editable-boolean

Conversation

@cbejensen

@cbejensencbejensen commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

Previously, the docs said editable can be set to true, but that is the default, so it makes more sense to say they can be set to false to change the default behavior.

@cbejensen
docs(stepper): update non-default boolean for editable prop
569a225
Previously, the docs said editable can be set to true, but that is the default, so it makes more sense to say they can be set to false to change the default behavior.
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 12, 2019
crisbeto
crisbeto approved these changes Feb 12, 2019
View reviewed changes

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbetocrisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 12, 2019
jelbourn
jelbourn approved these changes Feb 13, 2019
View reviewed changes

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
jelbourn merged commit e1d0024 into angular:masterFeb 13, 2019
jelbourn pushed a commit that referenced this pull request Feb 20, 2019
@cbejensen@jelbourn
docs(stepper): update non-default boolean for editable prop (#15161)
1af6f8c
Previously, the docs said editable can be set to true, but that is the default, so it makes more sense to say they can be set to false to change the default behavior.
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbetocrisbetocrisbeto approved these changes
@mmalerbammalerbaAwaiting requested review from mmalerba
+1 more reviewer
@jelbournjelbournjelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbejensen@jelbourn@crisbeto@googlebot