Uh oh!
There was an error while loading. Please reload this page.
chore(typescript): uniformly access all index signature with index ac… - #15206
Merged
Conversation
…cess. This is a strictness check that we are going to enforce in g3 internal typescript, to aid with optimization. Generally it is also syntactically a good idea to have visual indication when a type is accessed through an index signature vs not.
rkirov
requested review from
crisbeto, josephperrott and mmalerba
as code ownersFebruary 15, 2019 23:51
rkirov
commented
Feb 19, 2019
ContributorAuthor
Jeremy tells me I shouldn't have clicked on the big green button. Apologies to the caretaker, feel free to rollback as needed. |
Member
I'm thinking if it would be possible to create a lint rule for this that enforces this type of property access. At first glance it looks like we could easily end up introducing new incorrect property accesses. |
jelbourn pushed a commit
that referenced
this pull request
Feb 20, 2019
…cess. (#15206) This is a strictness check that we are going to enforce in g3 internal typescript, to aid with optimization. Generally it is also syntactically a good idea to have visual indication when a type is accessed through an index signature vs not.
rkirov added a commit
to rkirov/material2
that referenced
this pull request
Mar 19, 2019
This is a follow up to angular#15206, with these two changes all of material in conforming. A build-time check to enforce this is part of tsetse - https://tsetse.info/property-renaming-safe but I don't know how to turn it on for this repositories bazel builds.
rkirov
commented
Mar 19, 2019
ContributorAuthor
Better than a lint rule, we have a bazel tsetse check - https://tsetse.info/property-renaming-safe, however I don't know how to turn it on for your repo. |
andrewseguin pushed a commit
that referenced
this pull request
Mar 20, 2019
…#15523) This is a follow up to #15206, with these two changes all of material in conforming. A build-time check to enforce this is part of tsetse - https://tsetse.info/property-renaming-safe but I don't know how to turn it on for this repositories bazel builds.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Mar 30, 2019
Adds a lint rule to help catch cases like angular#15206 until we can get something going through tsetse. Note this is only scoped to `ngOnChanges` and accesses of the `SimpleChanges` objects since that's where we've been having issues.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cess.
This is a strictness check that we are going to enforce in g3 internal
typescript to aid with optimization. Generally, it is also syntactically
a good idea to have visual indication when a type is accessed through an
index signature vs not.