Uh oh!
There was an error while loading. Please reload this page.
feat(selection-list): support specifying theme color - #15237
Merged
jelbourn merged 1 commit intoFeb 22, 2019
Conversation
devversion
commented
Feb 19, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
devversionforce-pushed
the
feat/selection-list-support-theme-color
branch
from
February 19, 2019 20:17
2315b5c to
d57e6acCompareCurrently the selection list always uses the `accent` color for the underlying pseudo checkbox of list options. In order to make this configurable by the user, we add a `color` input that matches our other usages of the `color` input in order to be consistent. Since we want to allow that a color can be specified for the `<mat-selection-list>` and that it's possible to overwrite the color for an individual list option, we don't use the color mixin as it brings in a lot of overhead and also doesn't make it easy to provide the desired precedence for individual options. Also we **can't** set the color class on the `<mat-selection-list>` as the pseudo checkbox will then ignore the color class set for the individual list option. Closesangular#15234
devversionforce-pushed
the
feat/selection-list-support-theme-color
branch
from
February 19, 2019 20:19
d57e6ac to
50fa883CompareThis issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the selection list always uses the
accentcolor for the underlyingpseudo checkbox of list options. In order to make this configurable by the
user, we add a
colorinput that matches our other usages of thecolorinput in order to be consistent.
Since we want to allow that a color can be specified for the
<mat-selection-list>andthat it's possible to overwrite the color for an individual list option, we don't use the
color mixin as it brings in a lot of overhead and also doesn't make it easy to provide
the desired precedence for individual options. Also we can't set the color class
on the
<mat-selection-list>as the pseudo checkbox will then ignore the color classset for the individual list option.
Closes#15234